Skip to content

Enable jemalloc on MacOS#8046

Merged
Velfi merged 5 commits intodevfrom
zelda/enable-jemalloc-on-macos
Aug 13, 2025
Merged

Enable jemalloc on MacOS#8046
Velfi merged 5 commits intodevfrom
zelda/enable-jemalloc-on-macos

Conversation

@Velfi
Copy link
Contributor

@Velfi Velfi commented Aug 5, 2025

This PR enables the jemalloc allocator on MacOS by default. Previously, this was only done for Linux. We're making this change because it will make memory profiling easier than it currently is.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@apollo-librarian
Copy link

apollo-librarian bot commented Aug 5, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: bb012789bb0c53acf458d749
Build Logs: View logs

@github-actions

This comment has been minimized.

@Velfi Velfi marked this pull request as ready for review August 5, 2025 18:55
@Velfi Velfi requested a review from a team August 5, 2025 18:55
@Velfi Velfi requested a review from a team as a code owner August 5, 2025 19:07
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to consider windows. Please can you verify that either jemalloc will work on windows or reintroduce the feature gate so that we only cover the right platforms.

Edit: I see you specified unix. Ignore this.

@Velfi Velfi merged commit 4ada189 into dev Aug 13, 2025
15 checks passed
@Velfi Velfi deleted the zelda/enable-jemalloc-on-macos branch August 13, 2025 14:46
@lrlna lrlna mentioned this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants