Conversation
…Group/apollo-router into add-response-body-fields
…s.rs Co-authored-by: Zelda Hessler <zelda.hessler@pm.me>
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: 05bed93dffdbe8c5f0609e4c URL: https://www.apollographql.com/docs/deploy-preview/05bed93dffdbe8c5f0609e4c |
|
|
BrynCooke
left a comment
There was a problem hiding this comment.
This needs docs.
Also please can you verify that this has been manually tested in addition to the unit test in the PR.
|
Thanks @BrynCooke, I have provided a couple of entries in the selectors docs for the Router @Velfi, can you help me add these entries in this PR if all looks well on your end?
Yes, I can confirm that this has been manually tested and works as expected whenever errors are present in the router response (such as GraphQL validation/parsing errors) |
|
I renamed this branch which required creating a new PR #8158 |
Introducing the
ResponseErrorsselector in telemetry configurations to capture router response errors, allowing users to capture and log errors encountered at the router service layer. This new selector enhances logging for the router service, as it allows users the option to only log router errors instead of the entire router response body to reduce noise.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩