Entity caching: fix inconsistency in cache-control header handling#7987
Merged
SimonSapin merged 4 commits intodevfrom Jul 28, 2025
Merged
Entity caching: fix inconsistency in cache-control header handling#7987SimonSapin merged 4 commits intodevfrom
SimonSapin merged 4 commits intodevfrom
Conversation
…have one This fix an inconsistency in the header in the supergraph response between: * A query with a single fetch that is a cache miss * The same query with a cache hit
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 2 changed, 0 removedBuild ID: 07538ab9c16d88442b9d20bf URL: https://www.apollographql.com/docs/deploy-preview/07538ab9c16d88442b9d20bf |
This comment has been minimized.
This comment has been minimized.
bnjjj
approved these changes
Jul 28, 2025
SimonSapin
changed the title
bnjjj
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Subgraph Entity Caching feature is in use, it determines the
Cache-ControlHTTP response header sent to supergraph clients based on those received from subgraph servers.In this process, Apollo Router only emits the
max-agedirective and nots-maxage.This PR fixes a bug where, for a query that involved a single subgraph fetch that was not already cached, the subgraph response’s
Cache-Controlheader would be forwarded as-is.Instead, it now goes through the same algorithm as other cases.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩