Skip to content

fix(telemetry): improve error logging for custom trace_id generation#7910

Closed
juancarlosjr97 wants to merge 0 commit intoapollographql:devfrom
juancarlosjr97:dev
Closed

fix(telemetry): improve error logging for custom trace_id generation#7910
juancarlosjr97 wants to merge 0 commit intoapollographql:devfrom
juancarlosjr97:dev

Conversation

@juancarlosjr97
Copy link
Contributor

@juancarlosjr97 juancarlosjr97 commented Jul 17, 2025

#7909
This pull request improves logging in the CustomTraceIdPropagator implementation by enhancing the error message with additional context about the trace_id and the error.

Logging enhancement:


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@apollo-librarian
Copy link

apollo-librarian bot commented Jul 17, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 3 changed, 0 removed
* (developer-tools)/apollo-mcp-server/(latest)/command-reference.mdx
* graphos/routing/(latest)/cloud/configuration.mdx
* graphos/routing/(latest)/security/cors.mdx

Build ID: 08770f7846094381ad7797f2

URL: https://www.apollographql.com/docs/deploy-preview/08770f7846094381ad7797f2

@juancarlosjr97 juancarlosjr97 marked this pull request as ready for review July 22, 2025 14:32
@juancarlosjr97 juancarlosjr97 requested a review from a team July 22, 2025 14:32
@juancarlosjr97 juancarlosjr97 requested a review from a team as a code owner July 22, 2025 14:32
@juancarlosjr97
Copy link
Contributor Author

Hey, I am getting an error on CircleCI about GraphOS not being enabled - Error: test skipped because GraphOS is not enabled https://app.circleci.com/pipelines/github/apollographql/router/37557/workflows/2c27a7c8-c803-4c89-8605-8670e883091f/jobs/280712/tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant