Revert "Revert "Add _dd.measured to spans when agent sampling is enabled""#7833
Draft
Revert "Revert "Add _dd.measured to spans when agent sampling is enabled""#7833
Conversation
…led" (#7…" This reverts commit 2ee402c.
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 1 new, 2 changed, 0 removedBuild ID: c6023afc51e9e61a22714eed URL: https://www.apollographql.com/docs/deploy-preview/c6023afc51e9e61a22714eed |
| span.span_context.is_remote(), | ||
| span.span_context.trace_state().clone(), | ||
| ); | ||
| span.attributes.push(KeyValue::new("_dd.measured", 1)); |
Member
There was a problem hiding this comment.
This seems to happen for both the datadog exporter, and the OTLP exporter. The datadog exporter already configures measuring separately, so is it correct to do this here? I think it is duplicate for the DD exporter and could cause confusing interference in the future, and should probably only happen in OTLP.
Member
|
Marking this as a draft until it can get to the top of the stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7403
Reopening this PR so that we can see if there are conflicts while we get clarification from datadog.
The current situation where the APM view is not functional is unsustainable and adding yet another config to allow users to set measured on a per span basis is complicated.
Given that the behaviour in Router 1.x is that all spans are measured this feels like a regression rather than a nice to have.