Skip to content

Comments

Add back the graph artifact docs for the container#7752

Merged
mabuyo merged 2 commits intodevfrom
jl-apply-back-registry-container-docs
Jun 25, 2025
Merged

Add back the graph artifact docs for the container#7752
mabuyo merged 2 commits intodevfrom
jl-apply-back-registry-container-docs

Conversation

@lambertjosh
Copy link
Contributor

With the recent PR to add the Apollo runtime docs (#7734), some changes were accidentally lost related to graph artifacts. (See 8d19659 for the overwritten content)

This PR adds it back.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@lambertjosh lambertjosh requested a review from a team as a code owner June 25, 2025 05:53
@github-actions

This comment has been minimized.

@apollo-librarian
Copy link

apollo-librarian bot commented Jun 25, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 2 changed, 0 removed
* graphos/routing/(latest)/self-hosted/containerization/docker-router-only.mdx
* graphos/routing/(latest)/self-hosted/containerization/docker.mdx

Build ID: f0ae1a598c47d54b9b8fa774

URL: https://www.apollographql.com/docs/deploy-preview/f0ae1a598c47d54b9b8fa774

@lambertjosh
Copy link
Contributor Author

@jonathanrainer @mabuyo - can you do a quick review? This PR adds back the graph artifact docs which I accidentally overwrote with the prior PR.

Also @jonathanrainer - can you confirm if the graph artifact env var will work with the new container? I assumed it would so added it, since it just uses an ENV var, but not sure if we are doing some filtering of them.

@jonathanrainer
Copy link
Contributor

@jonathanrainer @mabuyo - can you do a quick review? This PR adds back the graph artifact docs which I accidentally overwrote with the prior PR.

Also @jonathanrainer - can you confirm if the graph artifact env var will work with the new container? I assumed it would so added it, since it just uses an ENV var, but not sure if we are doing some filtering of them.

Hi Josh,

Have had a look, and I think it all looks ok now. W.R.T the env var question, the answer is there's no reason it shouldn't work, with the obvious caveat that we'll have to release the Runtime Container with Router 2.4+ in it for it to work.

Copy link
Contributor

@jonathanrainer jonathanrainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mabuyo mabuyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 Ahh good catch, I had thought they were omitted intentionally 😅

@mabuyo mabuyo merged commit 73dc638 into dev Jun 25, 2025
15 checks passed
@mabuyo mabuyo deleted the jl-apply-back-registry-container-docs branch June 25, 2025 19:54
@abernix abernix mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants