Add back the graph artifact docs for the container#7752
Conversation
This comment has been minimized.
This comment has been minimized.
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 2 changed, 0 removedBuild ID: f0ae1a598c47d54b9b8fa774 URL: https://www.apollographql.com/docs/deploy-preview/f0ae1a598c47d54b9b8fa774 |
|
@jonathanrainer @mabuyo - can you do a quick review? This PR adds back the graph artifact docs which I accidentally overwrote with the prior PR. Also @jonathanrainer - can you confirm if the graph artifact env var will work with the new container? I assumed it would so added it, since it just uses an ENV var, but not sure if we are doing some filtering of them. |
Hi Josh, Have had a look, and I think it all looks ok now. W.R.T the env var question, the answer is there's no reason it shouldn't work, with the obvious caveat that we'll have to release the Runtime Container with Router 2.4+ in it for it to work. |
mabuyo
left a comment
There was a problem hiding this comment.
👍🏽 Ahh good catch, I had thought they were omitted intentionally 😅
With the recent PR to add the Apollo runtime docs (#7734), some changes were accidentally lost related to graph artifacts. (See 8d19659 for the overwritten content)
This PR adds it back.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩