Merged
Conversation
This comment has been minimized.
This comment has been minimized.
105268a to
a254f16
Compare
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 11 changed, 0 removedBuild ID: 99a2401e58b85f678b2a1cae URL: https://www.apollographql.com/docs/deploy-preview/99a2401e58b85f678b2a1cae |
Velfi
approved these changes
Jun 18, 2025
dylan-apollo
commented
Jun 18, 2025
| .wait_for_log_message(r#""subgraph":"connectors","message":"plugin `batching` indirectly targets a connector-enabled subgraph, which is not supported"#) | ||
| .await; | ||
| .wait_for_log_message(r#""subgraph":"connectors","message":"plugin `batching` indirectly targets a connector-enabled subgraph, which is not supported"#) | ||
| .await; |
Member
Author
There was a problem hiding this comment.
I'm not sure why all these reformatted for me but didn't trip CI previously 🤔
Velfi
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7389 switched from aws-lc to ring for crypto when talking to AWS. That change requires manually configuring a bunch of settings for AWS' SDK since we turned off default features. We missed a few configuration bits in that PR, which resulted in some SigV4 configurations failing at startup.
This PR addresses the issue by filling in the missing pieces.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions