Skip to content

Fix issue loading SigV4 config#7726

Merged
dylan-apollo merged 4 commits intodevfrom
dylan/aws-sigv4
Jun 20, 2025
Merged

Fix issue loading SigV4 config#7726
dylan-apollo merged 4 commits intodevfrom
dylan/aws-sigv4

Conversation

@dylan-apollo
Copy link
Member

@dylan-apollo dylan-apollo commented Jun 18, 2025

#7389 switched from aws-lc to ring for crypto when talking to AWS. That change requires manually configuring a bunch of settings for AWS' SDK since we turned off default features. We missed a few configuration bits in that PR, which resulted in some SigV4 configurations failing at startup.

This PR addresses the issue by filling in the missing pieces.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added[^3] and documented
  • Tests added and passing[^4]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

@github-actions

This comment has been minimized.

@apollo-librarian
Copy link

apollo-librarian bot commented Jun 18, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 11 changed, 0 removed
* (developer-tools)/apollo-mcp-server/(latest)/command-reference.mdx
* (developer-tools)/apollo-mcp-server/(latest)/guides/index.mdx
* (developer-tools)/kotlin/(latest)/index.mdx
* (developer-tools)/kotlin/(latest)/advanced/apollo-ast.mdx
* (developer-tools)/kotlin/(latest)/advanced/compiler-plugins.mdx
* (developer-tools)/kotlin/(latest)/advanced/no-runtime.mdx
* (developer-tools)/kotlin/(latest)/caching/http-cache.mdx
* (developer-tools)/kotlin/(latest)/caching/normalized-cache.mdx
* (developer-tools)/kotlin/(latest)/testing/apollo-debug-server.mdx
* (developer-tools)/kotlin/(latest)/testing/mocking-graphql-responses.mdx
* graphos/routing/(latest)/performance/caching/in-memory.mdx

Build ID: 99a2401e58b85f678b2a1cae

URL: https://www.apollographql.com/docs/deploy-preview/99a2401e58b85f678b2a1cae

.wait_for_log_message(r#""subgraph":"connectors","message":"plugin `batching` indirectly targets a connector-enabled subgraph, which is not supported"#)
.await;
.wait_for_log_message(r#""subgraph":"connectors","message":"plugin `batching` indirectly targets a connector-enabled subgraph, which is not supported"#)
.await;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why all these reformatted for me but didn't trip CI previously 🤔

@dylan-apollo dylan-apollo marked this pull request as ready for review June 18, 2025 21:44
@dylan-apollo dylan-apollo requested a review from a team June 18, 2025 21:44
@dylan-apollo dylan-apollo requested a review from a team as a code owner June 18, 2025 21:45
@dylan-apollo dylan-apollo requested a review from Velfi June 19, 2025 15:28
@dylan-apollo dylan-apollo merged commit 334a5f0 into dev Jun 20, 2025
15 checks passed
@dylan-apollo dylan-apollo deleted the dylan/aws-sigv4 branch June 20, 2025 16:43
@abernix abernix mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants