Skip to content

Revert #7316#7725

Merged
carodewig merged 2 commits intodevfrom
caroline/revert-7316
Jun 18, 2025
Merged

Revert #7316#7725
carodewig merged 2 commits intodevfrom
caroline/revert-7316

Conversation

@carodewig
Copy link
Contributor

@carodewig carodewig commented Jun 18, 2025

This PR reverts #7316 which moved the router's content negotiation to a plugin.

Moving the logic led to unintended side effects, including not allowing users to set custom accept headers on requests and content types on responses.

Fixes #7555


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@carodewig carodewig requested a review from a team June 18, 2025 15:03
@github-actions
Copy link
Contributor

@carodewig, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@abernix
Copy link
Member

abernix commented Jun 18, 2025

@carodewig do you agree this "Fixes #7555", too?

@carodewig
Copy link
Contributor Author

@carodewig do you agree this "Fixes #7555", too?

@abernix Yes it will, good catch!

@carodewig carodewig merged commit b20fd1d into dev Jun 18, 2025
13 checks passed
@carodewig carodewig deleted the caroline/revert-7316 branch June 18, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

router_service is not called early enough in 2.2.1

3 participants

Comments