Skip to content

[Error Counting] Use Builder for all router::Response Creation#7699

Merged
rregitsky merged 17 commits intodevfrom
rreg/err_count_response_refactor_PULSR_1504
Jun 17, 2025
Merged

[Error Counting] Use Builder for all router::Response Creation#7699
rregitsky merged 17 commits intodevfrom
rreg/err_count_response_refactor_PULSR_1504

Conversation

@rregitsky
Copy link
Contributor

@rregitsky rregitsky commented Jun 16, 2025

This converts all use of constructors to build router::Response objects into builders. This is done to force as many constructions as possible to go through new(), where we will later be adding errors to the response context so we can count them in the Telemetry plugin (handled in a later PR).

Part 1 of a split from #7357.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@github-actions
Copy link
Contributor

@rregitsky, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@apollo-librarian
Copy link

apollo-librarian bot commented Jun 16, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 2 changed, 0 removed
* (developer-tools)/apollo-mcp-server/(latest)/command-reference.mdx
* (developer-tools)/apollo-mcp-server/(latest)/guides/index.mdx

Build ID: 24993a8ec9f4a4c9d686d186

URL: https://www.apollographql.com/docs/deploy-preview/24993a8ec9f4a4c9d686d186

@rregitsky rregitsky marked this pull request as ready for review June 16, 2025 18:29
@rregitsky rregitsky requested a review from a team June 16, 2025 18:29
@rregitsky rregitsky merged commit 6d977dd into dev Jun 17, 2025
15 checks passed
@rregitsky rregitsky deleted the rreg/err_count_response_refactor_PULSR_1504 branch June 17, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants