Align on_graphql_error selector return values with subgraph_on_graphql_error

[carodewig]

Currently the subgraph_on_graphql_error selector will return true or false while the on_graphql_error selector will return true or None. This updates the on_graphql_error selector to return true or false to align with subgraph_on_graphql_error.

---

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

• Changes are compatible¹
• Documentation² completed
• Performance impact assessed and acceptable
• Metrics and logs are added³ and documented
• Tests added and passing⁴
  • Unit Tests
  • Integration Tests
  • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices. ↩

4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

[apollo-librarian]

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 2 changed, 0 removed

* (developer-tools)/apollo-mcp-server/(latest)/command-reference.mdx
* (developer-tools)/apollo-mcp-server/(latest)/guides/index.mdx

Build ID: b6e4fe5ad8ba553675fb5630

URL: https://www.apollographql.com/docs/deploy-preview/b6e4fe5ad8ba553675fb5630

[goto-bus-stop]

I don't quite understand, is this a user-visible change or an internal improvement? The new test seems to pass either way

[carodewig]

I don't quite understand, is this a user-visible change or an internal improvement? The new test seems to pass either way

@goto-bus-stop This is user visible! The test I added in 50a90d5 is a bit clearer. The current behavior of the router is to not include the attribute on the metric when the selector returns None (ie no attributes would be present on the new datapoints); this change makes the attribute visible as false instead.