Conversation
…subscriptions counter Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Collaborator
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 18 changed, 0 removedBuild ID: 7b98c8b2b5e28b90dae5f374 URL: https://www.apollographql.com/docs/deploy-preview/7b98c8b2b5e28b90dae5f374 |
…ross tokio tasks.
…operation_name_subscription_metric
….com:apollographql/router into bnjjj/add_operation_name_subscription_metric
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
carodewig
approved these changes
Jun 6, 2025
BrynCooke
approved these changes
Jun 9, 2025
BrynCooke
requested changes
Jun 9, 2025
Contributor
BrynCooke
left a comment
BrynCooke
left a comment
There was a problem hiding this comment.
Needs docs for the subscription metric updated.
….com:apollographql/router into bnjjj/add_operation_name_subscription_metric
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 22 changed, 0 removedBuild ID: 161290569748dcc2b656cc43 URL: https://www.apollographql.com/docs/deploy-preview/161290569748dcc2b656cc43 |
🛠️ Docs preview building...The preview is currently being built. Build ID: 161290569748dcc2b656cc43 |
3 similar comments
🛠️ Docs preview building...The preview is currently being built. Build ID: 161290569748dcc2b656cc43 |
🛠️ Docs preview building...The preview is currently being built. Build ID: 161290569748dcc2b656cc43 |
🛠️ Docs preview building...The preview is currently being built. Build ID: 161290569748dcc2b656cc43 |
BrynCooke
approved these changes
Jun 10, 2025
bnjjj
added a commit
that referenced
this pull request
Jun 10, 2025
…subscriptions counter (#7606) Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com> Co-authored-by: carodewig <16093297+carodewig@users.noreply.github.com> Co-authored-by: bryn <bryn@apollographql.com> (cherry picked from commit e7b7e40) # Conflicts: # apollo-router/src/metrics/mod.rs # docs/source/routing/observability/telemetry/instrumentation/standard-instruments.mdx
7 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new label on
apollo.router.opened.subscriptionsmetric to know exactly which subscription is still opened.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩