Skip to content

Comments

Measure extended errors in Apollo config telemetry#7597

Merged
timbotnik merged 2 commits intodevfrom
timbotnik/PULSR-1493/extended_errors_telemetry
Jun 2, 2025
Merged

Measure extended errors in Apollo config telemetry#7597
timbotnik merged 2 commits intodevfrom
timbotnik/PULSR-1493/extended_errors_telemetry

Conversation

@timbotnik
Copy link
Contributor

@timbotnik timbotnik commented Jun 2, 2025

Internal feature usage telemetry change.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@github-actions

This comment has been minimized.

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Jun 2, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: cfc2838362d40c39d5311e6c

@timbotnik timbotnik marked this pull request as ready for review June 2, 2025 03:55
@timbotnik timbotnik requested a review from a team June 2, 2025 03:55
@timbotnik timbotnik requested a review from a team as a code owner June 2, 2025 03:55
Copy link
Contributor

@bonnici bonnici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that we might need to revisit/update this dashboard once this is released: https://lookerstudio.google.com/u/0/reporting/ad7ec4f9-f655-4ceb-b507-98e20017751f/page/p_fny7n9rxjd

@timbotnik timbotnik merged commit 5514b3f into dev Jun 2, 2025
15 checks passed
@timbotnik timbotnik deleted the timbotnik/PULSR-1493/extended_errors_telemetry branch June 2, 2025 05:02
@abernix abernix mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants