Improve error message for invalid variables #7567
Merged
SimonSapin merged 6 commits intodevfrom Jun 3, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Collaborator
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 6 changed, 0 removedBuild ID: 8ef7510857f9c065b3f56db6 URL: https://www.apollographql.com/docs/deploy-preview/8ef7510857f9c065b3f56db6 |
lrlna
reviewed
Jun 3, 2025
Comment on lines
+120
to
+121
| // FIXME(SimonSapin): this causes every Rust field to be included in `extensions`, | ||
| // do we really want that? |
Member
There was a problem hiding this comment.
... what? that's wild. i want to say no? but maybe the original author of this snippet had something in mind?
Contributor
Author
There was a problem hiding this comment.
I guess it was a convenient shortcut that happened to have the desired effect for all variants the existed at the time, but it silently applied when new variants/fields were added
Co-authored-by: Renée <renee.kooi@apollographql.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
Fixes #2984
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩