Add configurable server header read timeout (backport #7262)#7353
Merged
Add configurable server header read timeout (backport #7262)#7353
Conversation
(cherry picked from commit f008bf3)
(cherry picked from commit 8683f3a) # Conflicts: # apollo-router/src/configuration/mod.rs
(cherry picked from commit bca998b) # Conflicts: # apollo-router/src/axum_factory/axum_http_server_factory.rs # apollo-router/src/axum_factory/listeners.rs
(cherry picked from commit de2127f) # Conflicts: # apollo-router/src/axum_factory/axum_http_server_factory.rs # apollo-router/src/axum_factory/listeners.rs
(cherry picked from commit 1b19574) # Conflicts: # apollo-router/src/configuration/snapshots/apollo_router__configuration__tests__schema_generation.snap
(cherry picked from commit b9099ff)
(cherry picked from commit 8e22896)
(cherry picked from commit f0aa17d) # Conflicts: # apollo-router/src/axum_factory/listeners.rs
Contributor
|
Cherry-pick of 8683f3a has failed: Cherry-pick of bca998b has failed: Cherry-pick of de2127f has failed: Cherry-pick of 1b19574 has failed: Cherry-pick of f0aa17d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Collaborator
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: be689022ee507e54beb06001 URL: https://www.apollographql.com/docs/deploy-preview/be689022ee507e54beb06001 |
eca0f74 to
a9ca055
Compare
a9ca055 to
c4eae7b
Compare
BrynCooke
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change exposes the server's header read timeout as the
server.http.header_read_timeoutconfiguration option.By default, the
server.http.header_read_timeoutis set to previously hard-coded 10 seconds. A longer timeout can be configured using theserver.http.header_read_timeoutoption.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
This is an automatic backport of pull request #7262 done by [Mergify](https://mergify.com).
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩