coprocessor: fix parsing of graphql responses with null as data (backport #7141)#7315
Merged
IvanGoncharov merged 2 commits into1.xfrom Apr 22, 2025
Merged
coprocessor: fix parsing of graphql responses with null as data (backport #7141)#7315IvanGoncharov merged 2 commits into1.xfrom
data (backport #7141)#7315IvanGoncharov merged 2 commits into1.xfrom
Conversation
) (cherry picked from commit 388afab) # Conflicts: # apollo-router/src/graphql/request.rs # apollo-router/src/metrics/mod.rs # apollo-router/src/plugins/coprocessor/execution.rs # apollo-router/src/plugins/coprocessor/supergraph.rs # apollo-router/src/plugins/coprocessor/test.rs
Contributor
|
Cherry-pick of 388afab has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
6 tasks
Collaborator
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 3f23923a76d1e2acf33704af |
4d5089b to
910a488
Compare
|
CI performance tests
|
BrynCooke
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coprocessor deserialized GraphQL response using serde_json directly that resulted in
data: nullwere ignored.After my change, it's using
Response::from_value, which applies the same steps for parsing GraphQL response that we are already using for parsing subgraph response.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
[ROUTER-1219]: https://apollographql.atlassian.net/browse/ROUTER-1219?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This is an automatic backport of pull request #7141 done by Mergify.
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩