Improve performance of query hashing by using a precomputed schema hash (backport #6622)#6631
Merged
Improve performance of query hashing by using a precomputed schema hash (backport #6622)#6631
Conversation
…sh (#6622) Co-authored-by: Simon Sapin <simon@apollographql.com> Co-authored-by: Renée Kooi <renee.kooi@apollographql.com> (cherry picked from commit 8c81327) # Conflicts: # apollo-router/src/query_planner/bridge_query_planner.rs # apollo-router/src/query_planner/caching_query_planner.rs # apollo-router/src/query_planner/fetch.rs # apollo-router/src/query_planner/snapshots/apollo_router__query_planner__bridge_query_planner__tests__plan_root.snap # apollo-router/src/spec/query/change.rs # apollo-router/src/spec/schema.rs # apollo-router/tests/integration/redis.rs # apollo-router/tests/snapshots/type_conditions___test_type_conditions_disabled.snap # apollo-router/tests/snapshots/type_conditions___test_type_conditions_enabled.snap # apollo-router/tests/snapshots/type_conditions___test_type_conditions_enabled_generate_query_fragments.snap # apollo-router/tests/snapshots/type_conditions___test_type_conditions_enabled_list_of_list.snap # apollo-router/tests/snapshots/type_conditions___test_type_conditions_enabled_list_of_list_of_list.snap # apollo-router/tests/snapshots/type_conditions___test_type_conditions_enabled_shouldnt_make_article_fetch.snap
This comment was marked as resolved.
This comment was marked as resolved.
|
@mergify[bot]: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
6 tasks
Collaborator
|
|
CI performance tests
|
lrlna
approved these changes
Jan 23, 2025
abernix
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the query hashing back to a simpler algorithm, which is faster and has more predictable CPU and memory costs.
Previous vs. New Algorithm
Key Change
Benefits of the New Approach
Implementation Details
SchemaHashtype has been introduced and the existingQueryHashtype refined.QueryHashis now created viaSchemaHash::operation_hashwith a query string and optional operation name.Future Plan
QueryHashcreation for now, but they will be removed in subsequent PRs.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
[ROUTER-978]: https://apollographql.atlassian.net/browse/ROUTER-978?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This is an automatic backport of pull request #6622 done by Mergify.
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩