Skip to content

update CircleCI base image#6553

Merged
nicholascioli merged 9 commits intonextfrom
nc/circleci-image-update
Jan 16, 2025
Merged

update CircleCI base image#6553
nicholascioli merged 9 commits intonextfrom
nc/circleci-image-update

Conversation

@nicholascioli
Copy link
Contributor

@nicholascioli nicholascioli commented Jan 15, 2025

This commit fixes an issue with a downstream dependency (aws-lc-sys) caused by using an old version of GCC by updating the base CircleCI image to current.

This was realistically a long-time coming because the previous tag of stable was deprecated in favor of current back in 2022.

Below is a quote from the docker hub page explaining the change to the tag names:

current - This image tag points to the latest, production ready base image. This is a replacement for the old stable tag. This image should be used by projects that want a decent level of stability but would like to get occasional software updates. It is typically updated once a month.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

This commit fixes an issue with a downstream dependency
(`aws-lc-sys`) caused by using an old version of GCC by updating
the base CircleCI image to `current`.

This was realistically a long-time coming because the previous
tag of `stable` was deprecated in favor of `current` back in 2022.

Below is a quote from the [docker hub page](https://hub.docker.com/r/cimg/base)
explaining the change to the tag names:

| current - This image tag points to the latest, production ready
| base image. This is a replacement for the old stable tag. This
| image should be used by projects that want a decent level of
| stability but would like to get occasional software updates.
| It is typically updated once a month.
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Jan 15, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 154865137699ba2c9c102894

@nicholascioli
Copy link
Contributor Author

A required dependency was not found during setup, so I've added a sudo apt-get update to the setup instructions to repopulate the package cache. This does add some non-determinism to the build process, since packages can update between invocations of CircleCI, but it should be mitigated by the fact that only security and patch updates are pushed to LTS versions of Ubuntu.

@nicholascioli nicholascioli merged commit be6736b into next Jan 16, 2025
@nicholascioli nicholascioli deleted the nc/circleci-image-update branch January 16, 2025 20:40
@router-perf
Copy link

router-perf bot commented Jan 17, 2025

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants