Merged
Conversation
This commit fixes an issue with a downstream dependency (`aws-lc-sys`) caused by using an old version of GCC by updating the base CircleCI image to `current`. This was realistically a long-time coming because the previous tag of `stable` was deprecated in favor of `current` back in 2022. Below is a quote from the [docker hub page](https://hub.docker.com/r/cimg/base) explaining the change to the tag names: | current - This image tag points to the latest, production ready | base image. This is a replacement for the old stable tag. This | image should be used by projects that want a decent level of | stability but would like to get occasional software updates. | It is typically updated once a month.
Collaborator
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 154865137699ba2c9c102894 |
Contributor
Author
|
A required dependency was not found during setup, so I've added a |
lennyburdette
approved these changes
Jan 16, 2025
|
CI performance tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with a downstream dependency (
aws-lc-sys) caused by using an old version of GCC by updating the base CircleCI image tocurrent.This was realistically a long-time coming because the previous tag of
stablewas deprecated in favor ofcurrentback in 2022.Below is a quote from the docker hub page explaining the change to the tag names:
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩