Skip to content

POC: Make supergraph creator clone a BoxCloneService#6540

Merged
garypen merged 3 commits intogarypen/next-backpressurefrom
garypen/one-supergraph
Jan 14, 2025
Merged

POC: Make supergraph creator clone a BoxCloneService#6540
garypen merged 3 commits intogarypen/next-backpressurefrom
garypen/one-supergraph

Conversation

@garypen
Copy link
Contributor

@garypen garypen commented Jan 13, 2025

This breaks all the http_post_mutation tests because of changes in expectation.

It's an interesting experiment though and worth discussing.

===UPDATE===

I've fixed the tests and fixed the AsyncCheckPointService, so I think this is worth merging into the main backpressure branch at this point.

This breaks all the http_post_mutation tests because of changes in
expectation.
@garypen garypen self-assigned this Jan 13, 2025
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Jan 13, 2025

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch garypen/next-backpressure is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch next
  • !docs set-base-branch main

Build ID: 428ced22d7999e43377f11b4

The AsyncCheckpoint layer was using `oneshot` and wasn't calling the
prepared service. I've fixed that.

This affects some of the tests, so I've fixed them as well.
@garypen garypen marked this pull request as ready for review January 14, 2025 12:35
@garypen garypen requested a review from a team January 14, 2025 12:35
@garypen garypen requested a review from a team as a code owner January 14, 2025 12:35
Copy link
Contributor

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only thing I'm worried is buffer.
I think it's ok in this particular PR as incremental change but I think we need to have a separate task to remove all buffer calls (outside of tests) that we added during this refactoring

@garypen garypen merged commit a8a8950 into garypen/next-backpressure Jan 14, 2025
@garypen garypen deleted the garypen/one-supergraph branch January 14, 2025 13:35
@router-perf
Copy link

router-perf bot commented Jan 17, 2025

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants