POC: Make supergraph creator clone a BoxCloneService#6540
Merged
garypen merged 3 commits intogarypen/next-backpressurefrom Jan 14, 2025
Merged
POC: Make supergraph creator clone a BoxCloneService#6540garypen merged 3 commits intogarypen/next-backpressurefrom
garypen merged 3 commits intogarypen/next-backpressurefrom
Conversation
This breaks all the http_post_mutation tests because of changes in expectation.
Collaborator
|
The AsyncCheckpoint layer was using `oneshot` and wasn't calling the prepared service. I've fixed that. This affects some of the tests, so I've fixed them as well.
IvanGoncharov
approved these changes
Jan 14, 2025
Contributor
IvanGoncharov
left a comment
There was a problem hiding this comment.
Looks good, the only thing I'm worried is buffer.
I think it's ok in this particular PR as incremental change but I think we need to have a separate task to remove all buffer calls (outside of tests) that we added during this refactoring
|
CI performance tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks all the http_post_mutation tests because of changes in expectation.
It's an interesting experiment though and worth discussing.
===UPDATE===
I've fixed the tests and fixed the
AsyncCheckPointService, so I think this is worth merging into the main backpressure branch at this point.