Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
goto-bus-stop
commented
Dec 17, 2024
Comment on lines
+570
to
+647
| // Tie the lifetime of the session count instrument to the lifetime of the router | ||
| // by moving it into a no-op layer. | ||
| let instrument = session_count_instrument(); | ||
| router = router.layer(layer_fn(move |service| { | ||
| let _ = &instrument; | ||
| service | ||
| })); |
Member
Author
There was a problem hiding this comment.
The session_count_active instrument is "stored" in an axum::Router instance by moving it into a no-op layer. Another option would be to just have one global instrument for the entire lifetime of the program, but I'm not sure if that would work everywhere we need it to (eg. does it do the right thing across reloads, tests, etc?)
|
CI performance tests
|
goto-bus-stop
commented
Dec 17, 2024
Comment on lines
+276
to
+264
| #[derive(Debug)] | ||
| struct SpanLruSizeInstrument { | ||
| value: Arc<AtomicU64>, | ||
| _gauge: ObservableGauge<u64>, | ||
| } |
Member
Author
There was a problem hiding this comment.
As mentioned in the doc comment, this is a hack that kind of mimicks what tracing::info!(value.) was doing (storing the value whenever it is updated, and reading the stored value when requested).
I'm not sure about this metric, should we keep it at all in 2.0?
Contributor
There was a problem hiding this comment.
I think we should keep it. It's really helpful to debug and could potentially find the root cause of a leak or so.
goto-bus-stop
changed the title
value.* metrics to gaugesvalue.* metrics to gauges
goto-bus-stop
force-pushed
the
renee/ROUTER-297-values
branch
from
27a4a08 to
1b4616b
Compare
bnjjj
approved these changes
Dec 20, 2024
Comment on lines
+276
to
+264
| #[derive(Debug)] | ||
| struct SpanLruSizeInstrument { | ||
| value: Arc<AtomicU64>, | ||
| _gauge: ObservableGauge<u64>, | ||
| } |
Contributor
There was a problem hiding this comment.
I think we should keep it. It's really helpful to debug and could potentially find the root cause of a leak or so.
This comment has been minimized.
This comment has been minimized.
goto-bus-stop
added a commit
that referenced
this pull request
Dec 20, 2024
Somehow missed this in #6476 <!-- [ROUTER-911] -->
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
tracing::info!(value.)metrics to otel instruments.Notes in comments