release: v1.59.0 by bnjjj · Pull Request #6438 · apollographql/router

bnjjj · 2024-12-11T13:19:58Z

Note
This particular PR must be true-merged to main.

This PR is only ready to review when it is marked as "Ready for Review". It represents the merge to the main branch of an upcoming release (version number in the title).
It will act as a staging branch until we are ready to finalize the release.
We may cut any number of alpha and release candidate (RC) versions off this branch prior to formalizing it.
This PR is primarily a merge commit, so reviewing every individual commit shown below is not necessary since those have been reviewed in their own PR. However, things important to review on this PR once it's marked "Ready for Review":
- Does this PR target the right branch? (usually, main)
- Are the appropriate version bumps and release note edits in the end of the commit list (or within the last few commits). In other words, "Did the 'release prep' PR actually land on this branch?"
- If those things look good, this PR is good to merge!

Adds an initial plugin, that loads at startup and emits metrics for three simple cases: cpus, cpu_freq and total_memory.

Also improve how we handle refreshing the System object, rather than doing it in either the callback or the async task, contain that within a struct and do it there.

Ensures that gauges will survive hot reload

…ected

1. activate is made non-async. It must never fail and it must complete. async fns can halt execution before completion. 2. The spawned thread and channel for fleet detector is removed. There's no need for these. Gauges will be called periodically for export. 3. Telemetry is converted to PrivatePlugin to allow uniform calls to activate.

…ndling (#6325)

Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>

…disabled (#6282)

Co-authored-by: Renée <renee.kooi@apollographql.com> Co-authored-by: Jesse Rosenberger <git@jro.cc>

) The router's native, Rust-based, query planner is now generally available and enabled by default. The native query planner achieves better performance for a variety of graphs. In our tests, we observe: * 10x median improvement in query planning time (observed via `apollo.router.query_planning.plan.duration`) * 2.9x improvement in router’s CPU utilization * 2.2x improvement in router’s memory usage > Note: you can expect generated plans and subgraph operations in the native query planner to have slight differences when compared to the legacy, JavaScript-based query planner. We've ascertained these differences to be semantically insignificant, based on comparing ~2.5 million known unique user operations in GraphOS as well as comparing ~630 million operations across actual router deployments in shadow mode for a four month duration. The native query planner supports Federation v2 supergraphs. If you are using Federation v1 today, see our migration guide on how to update your composition build step and subgraph changes are typically not needed. The legacy, JavaScript, query planner is deprecated in this release, but you can still switch back to it if you are still using Federation v1 supergraph: ```yaml experimental_query_planner_mode: legacy ``` > Note: The subgraph operations generated by the query planner are not guaranteed consistent release over release. We strongly recommend against relying on the shape of planned subgraph operations, as new router features and optimizations will continuously affect it. Co-authored-by: Chandrika Srinivasan <chandrikas@users.noreply.github.com> Co-authored-by: Edward Huang <edward.huang@apollographql.com> Co-authored-by: Shane Myrick <mail@shanemyrick.com>

lrlna · 2024-12-12T13:20:12Z

the docs for QP GA are in now too^^

.changesets/breaking_drop_reuse_fragment.md

.changesets/breaking_glasser_pq_metric_attribute_consistency.md

.changesets/config_simon_router_version_in_cache_key.md

.changesets/docs_fix_helm_yaml_config_link.md

.changesets/feat_feat_fleet_detector_add_schema_metrics.md

.changesets/fix_fix_query_hashing.md

.changesets/maint_lrlna_remove_catch_unwind.md

.changesets/maint_renee_router_297_monotonic_counters.md

Co-authored-by: Edward Huang <edward.huang@apollographql.com>

.changesets/breaking_drop_reuse_fragment.md

As per docs suggestion, remove this changeset

BrynCooke

Block

shorgi · 2024-12-16T17:03:45Z

.changesets/breaking_drop_reuse_fragment.md

+### Drop experimental reuse fragment query optimization option ([PR #6354](https://github.com/apollographql/router/pull/6354))
+
+Drop support for the experimental reuse fragment query optimization. This implementation was not only very slow but also very buggy due to its complexity.
+
+Auto generation of fragments is a much simpler (and faster) algorithm that in most cases produces better results. Fragment auto generation is the default optimization since v1.58 release.


Suggested change

### Drop experimental reuse fragment query optimization option ([PR #6354](https://github.com/apollographql/router/pull/6354))

Drop support for the experimental reuse fragment query optimization. This implementation was not only very slow but also very buggy due to its complexity.

Auto generation of fragments is a much simpler (and faster) algorithm that in most cases produces better results. Fragment auto generation is the default optimization since v1.58 release.

### Drop experimental reuse fragment query optimization option ([PR #6354](https://github.com/apollographql/router/pull/6354))

We've dropped support for the `experimental_reuse_query_fragments` option. Its implementation didn't achieve good enough performance or reliability.

In its place, the router uses fragment auto generation. As the default implementation since router v1.58, in most cases fragment auto generation achieves better performance and results.

Sorry the prep already happened.

jonathanrainer and others added 30 commits November 12, 2024 22:05

FLEET-19 Update filter and add new dependencies

93050d4

FLEET-19 Add initial take on Fleet Detection Plugin

107d37d

Adds an initial plugin, that loads at startup and emits metrics for three simple cases: cpus, cpu_freq and total_memory.

FLEET-19 Fixing CI with new schema generation

fefd8a4

FLEET-19 Use correct metrics form

f600f29

Also improve how we handle refreshing the System object, rather than doing it in either the callback or the async task, contain that within a struct and do it there.

FLEET-19 Implement new activate hook

aaa789d

FLEET-19 Move to gauges

e3e5c24

Ensures that gauges will survive hot reload

FLEET-19 Turn off Fleet Detection if APOLLO_TELEMETRY_DISABLED is det…

4bd425c

…ected

FLEET-19 Add CHANGELOG Entry

245aad6

FLEET-19 Get rid of unwraps

c1ec7c7

plugins/fleet_detector: add schema and persisted_queries gauges

533aae7

add comments

c3f75ce

add gauge store options

64adb53

Merge branch '1.58.0' into dev

56a49b2

Context test rewriter assertion (#6319)

62b4a75

fix gauge attributes list

78a3cfc

fix lint issues

7be0703

chore(federation): add unit tests and documentation for conditions ha…

dc0426c

…ndling (#6325)

add SchemaState

9a8c734

fix stream map closure

5c5a604

fix deref addrof

894e429

docs: router setup for Datadog (#6008)

214b2e4

fix(telemetry): fix supergraph query selector (#6324)

6037663

Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>

plugin: add launch_id

00640a8

fix type cast

9842d32

fix plugin types

1d469a1

Allow non-trivial root __typename-only queries when introspection is …

e73e94f

…disabled (#6282)

add launch_id to schema

207f3b6

fix(federation): avoid constantly recomputing conditions (#6326)

1c85fa8

Fix YAML reference URL link in values.yaml (#6277)

5d25d92

Co-authored-by: Renée <renee.kooi@apollographql.com> Co-authored-by: Jesse Rosenberger <git@jro.cc>

bnjjj and others added 2 commits December 11, 2024 14:27

prep release: v1.59.0-rc.0

2caf265

shorgi reviewed Dec 13, 2024

View reviewed changes

Apply suggestions from code review

99b57b0

Co-authored-by: Edward Huang <edward.huang@apollographql.com>

BrynCooke marked this pull request as ready for review December 16, 2024 11:00

BrynCooke requested a review from a team December 16, 2024 11:00

BrynCooke requested review from a team, SimonSapin, TylerBloom, benjamn, dariuszkuc, duckki, goto-bus-stop, lrlna and sachindshinde as code owners December 16, 2024 11:00

BrynCooke and others added 2 commits December 16, 2024 11:02

Apply suggestions from code review

f8bb276

Co-authored-by: Edward Huang <edward.huang@apollographql.com>

Apply suggestions from code review

5a2b33c

Co-authored-by: Edward Huang <edward.huang@apollographql.com>

BrynCooke reviewed Dec 16, 2024

View reviewed changes

.changesets/breaking_drop_reuse_fragment.md Outdated Show resolved Hide resolved

Delete .changesets/docs_fix_helm_yaml_config_link.md

ef1a282

As per docs suggestion, remove this changeset

BrynCooke requested changes Dec 16, 2024

View reviewed changes

Update .changesets/breaking_drop_reuse_fragment.md

d15894e

shorgi reviewed Dec 16, 2024

View reviewed changes

prep release: v1.59.0

bd8ea14

BrynCooke enabled auto-merge December 17, 2024 10:36

BrynCooke approved these changes Dec 17, 2024

View reviewed changes

goto-bus-stop approved these changes Dec 17, 2024

View reviewed changes

BrynCooke merged commit 3bdcacd into main Dec 17, 2024

BrynCooke deleted the 1.59.0 branch December 17, 2024 10:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release: v1.59.0#6438

release: v1.59.0#6438
BrynCooke merged 140 commits intomainfrom
1.59.0

bnjjj commented Dec 11, 2024

Uh oh!

lrlna commented Dec 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BrynCooke left a comment

Uh oh!

shorgi Dec 16, 2024

Uh oh!

BrynCooke Dec 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

bnjjj commented Dec 11, 2024

Uh oh!

lrlna commented Dec 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BrynCooke left a comment

Choose a reason for hiding this comment

Uh oh!

shorgi Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

BrynCooke Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants