Cleanup unused bypass QP functionality

[dariuszkuc]

Cleanup query planner code by removing unused bypass QP functionality. This was a gateway only feature that was never supported on the router.

---

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

• Changes are compatible¹
• Documentation² completed
• Performance impact assessed and acceptable
• Tests added and passing³
  • Unit Tests
  • Integration Tests
  • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

[svc-apollo-docs]

✅ Docs Preview Ready

No new or changed pages found.

[github-actions]

@dariuszkuc, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

[router-perf]

CI performance tests

• connectors-const - Connectors stress test that runs with a constant number of users
• const - Basic stress test that runs with a constant number of users
• demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
• demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
• enhanced-signature - Enhanced signature enabled
• events - Stress test for events with a lot of users and deduplication ENABLED
• events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
• events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
• events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
• events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
• events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
• extended-reference-mode - Extended reference mode enabled
• large-request - Stress test with a 1 MB request payload
• no-tracing - Basic stress test, no tracing
• reload - Reload test over a long period of time at a constant rate of users
• step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
• step-local-metrics - Field stats that are generated from the router rather than FTV1
• step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
• step - Basic stress test that steps up the number of users over time
• xlarge-request - Stress test with 10 MB request payload
• xxlarge-request - Stress test with 100 MB request payload

[duckki]

Looks good!

[dariuszkuc]

Looks like this one also impacts the QP redis cache tests -> I'll wait for the #6354 before fixing this

[goto-bus-stop]

Love to see it, thanks for doing that 😁

[lrlna]

Looks like this one also impacts the QP redis cache tests -> I'll wait for the #6354 before fixing this

Yea, QueryPlannerConfig is part of the cache key (which is generally good, but bad for when we change the config)

[dariuszkuc]

@lrlna @SimonSapin am I missing something around redis cache key tests? I'd expect that this change should have also affected the query_planner_redis_update_reuse_query_fragments test but it seems like it didn't update the cache key? Just want to double check whether it is expected -> I'm guessing it didn't change the expected cache key there as in order to reuse fragments we have to explicitly switch back to the legacy QP and this config change only affects the native QP.

[lrlna]

we talked about this in a huddle, but for historical sake and anyone observing from a distance:

• query_planner_redis_update_reuse_query_fragments did not need its cache keys changed
  • it's using the legacy query planner explicitly with the legacy query planner's config
  • legacy query planner config was not affected as part of these changes