Skip to content

Dk/drop reuse fragments #6353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dariuszkuc wants to merge 4 commits into from
Closed

Dk/drop reuse fragments #6353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1a2e50
[federation] drop experimental reuse fragment optimization
dariuszkuc Nov 27, 2024
19710d1
drop fragment rebasing logic
dariuszkuc Nov 27, 2024
e32fa6b
default to empty fragments for normalized operation
dariuszkuc Nov 27, 2024
abd7fce
remove unused rebasing code
dariuszkuc Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apollo-federation/src/operation/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3911,7 +3911,9 @@ pub(crate) fn normalize_operation(
variables: Arc::new(operation.variables.clone()),
directives: operation.directives.clone().into(),
selection_set: normalized_selection_set,
named_fragments,
// fragments were already expanded into selection sets
// new ones will be generated when optimizing the final subgraph fetch operations
named_fragments: Default::default(),
};
Ok(normalized_operation)
}
Expand Down
674 changes: 0 additions & 674 deletions apollo-federation/src/operation/optimize.rs
View file
Open in desktop

Large diffs are not rendered by default.

Loading