plugins/fleet_detector: add schema and persisted_queries gauges#6283
Merged
plugins/fleet_detector: add schema and persisted_queries gauges#6283
Conversation
Collaborator
✅ Docs Preview ReadyNo new or changed pages found. |
|
CI performance tests
|
Contributor
Author
|
Marking this ready for initial review so I can get feedback before fixing tests and pulling launch_id from uplink. |
BrynCooke
approved these changes
Dec 2, 2024
This comment has been minimized.
This comment has been minimized.
BrynCooke
approved these changes
Dec 6, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an additional metric to the
fleet_detectorplugin in the form of:apollo.router.instance.schemawith 2 attributes:schema_hashandlaunch_id.In order to pass a
launch_idto the plugin builder, changes were made to theUpdateSchemavariant of theEventenum in order to pass a newSchemaStatestruct instead of just an SDL string.Tested via using OpenTelemetry Collector with the following router config and OTEL config
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩