feat: enable both_best_effort query planners#5860
Merged
Conversation
bnjjj
approved these changes
Aug 21, 2024
chandrikas
approved these changes
Aug 21, 2024
Contributor
chandrikas
left a comment
chandrikas
left a comment
There was a problem hiding this comment.
Looks good as is. However, I was wondering if we could have a "learn more" link. As a user when I read this, my first thought is - "It can't be for free. What's the impact? They say it's not in the hot path but what do I need to know before I decide I should leave this on or off"
Member
Author
|
@chandrikas do you mean having a docs page for this as well? |
Contributor
|
Can we have a hidden docs page for now that can be removed later? |
Member
Author
|
@chandrikas I'll talk to the docs team about it! I am going to merge this in, and we can edit the changelog in the release prep PR. I need to try to get an rc out with the code change today 🙏 |
lrlna
changed the title
This reverts commit c09e255.
Redis cache key uses the planner_mode kind as part of its cache key. Since we are enabling `both_best_effort`, the cache key will change, and we have to update its keys.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formally switches
#[default]toboth_best_effortforexperimental_query_planner_modeand adds a changelog entry.