Fix session counting and the reporting of file handle shortage#5834
Merged
Fix session counting and the reporting of file handle shortage#5834
Conversation
Session counting incorrectly included connections to the health check or other non-graphql connections. This is now corrected so that only connections to the main graphql port are counted. Warnings about file handle shortages are now handled correctly as a global resource.
This comment has been minimized.
This comment has been minimized.
|
CI performance tests
|
added 2 commits
August 16, 2024 12:19
The listener had its own custom rate limiting for log messages. The router comes with a standard mechanism for rate limiting log messages. Remove the custom rate limiting mechanism and advised in the changelog that standard rate limiting configuration should be used.
BrynCooke
approved these changes
Aug 16, 2024
Contributor
BrynCooke
left a comment
There was a problem hiding this comment.
Approved, but put in the description of the PR that this was manually tested and cannot be unit tested.
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session counting incorrectly included connections to the health check or other non-graphql connections. This is now corrected so that only connections to the main graphql port are counted.
Warnings about file handle shortages are now handled correctly as a global resource.
Note: This was manually tested since integration/unit testing isn't really viable.