Skip to content

Use consistent query name in uplink metrics#5816

Merged
goto-bus-stop merged 2 commits intodevfrom
renee/consistent-uplink-type
Aug 19, 2024
Merged

Use consistent query name in uplink metrics#5816
goto-bus-stop merged 2 commits intodevfrom
renee/consistent-uplink-type

Conversation

@goto-bus-stop
Copy link
Member

I'm not sure if this is a legitimate issue but it looks weird.

The apollo_router_uplink_fetch_duration_seconds metric has a query attribute which normally contains a simplified name, such as license for apollo_router::uplink::LicenseQuery or persistentquerymanifest for apollo_router::uplink::PersistentQueryManifestQuery.

But if the uplink fetch fails, the query attribute instead contains the whole type name, apollo_router::uplink::licensequery instead of license.

I suspect these were meant to be the same?

@goto-bus-stop goto-bus-stop requested a review from a team August 14, 2024 09:13
@goto-bus-stop goto-bus-stop requested a review from a team as a code owner August 14, 2024 09:13
@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Aug 14, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@goto-bus-stop goto-bus-stop force-pushed the renee/consistent-uplink-type branch from a99bb88 to d2fea7d Compare August 19, 2024 07:31
@goto-bus-stop goto-bus-stop merged commit ae522fb into dev Aug 19, 2024
@goto-bus-stop goto-bus-stop deleted the renee/consistent-uplink-type branch August 19, 2024 08:05
@abernix abernix mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants