Use consistent query name in uplink metrics#5816
Merged
goto-bus-stop merged 2 commits intodevfrom Aug 19, 2024
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
CI performance tests
|
lrlna
approved these changes
Aug 14, 2024
a99bb88 to
d2fea7d
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is a legitimate issue but it looks weird.
The
apollo_router_uplink_fetch_duration_secondsmetric has aqueryattribute which normally contains a simplified name, such aslicenseforapollo_router::uplink::LicenseQueryorpersistentquerymanifestforapollo_router::uplink::PersistentQueryManifestQuery.But if the uplink fetch fails, the query attribute instead contains the whole type name,
apollo_router::uplink::licensequeryinstead oflicense.I suspect these were meant to be the same?