(bug) Trace propagation via header doesn't work #5802
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
CI performance tests
|
shorgi
reviewed
Aug 12, 2024
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
garypen
approved these changes
Aug 14, 2024
bnjjj
reviewed
Aug 19, 2024
Comment on lines
+5
to
+11
| ```yaml | ||
| exporters: | ||
| tracing: | ||
| propagation: | ||
| request: | ||
| header_name: "id_from_header" | ||
| ``` |
Merged
|
Just for clarification, when not using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When propagating trace ID via header:
The trace ID was not being correctly transferred to the root span of the request. This resulted in spans being incorrectly attributed to a new trace.
During propagation the trace ID was injected into a remote span with an invalid span ID.
This is then set as the context so that the subsequent root span can pick this up.
However, the root span creation logic checks that the parent span is valid, which it isn't and then created a brand new trace.
The logic is now modified to also check if the trace ID alone is valid.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
This is covered by integration tests rather than unit tests as it requires a tracing functionality to be fully set up.
No docs updates required
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩