connectors: expand JSONSelection in transport body#5799
Merged
nicholascioli merged 3 commits intonextfrom Aug 13, 2024
Merged
Conversation
|
CI performance tests
|
lennyburdette
approved these changes
Aug 12, 2024
Contributor
There was a problem hiding this comment.
what should happen here?
Member
There was a problem hiding this comment.
@lennyburdette This Key::Index variant is going away in #5762, specifically in commit 01bb990.
Contributor
Author
There was a problem hiding this comment.
I've changed it to return a [] for now until the PR mentioned above gets merged.
apollo-federation/src/sources/connect/json_selection/parameter_extraction.rs
Outdated
Show resolved
Hide resolved
Contributor
|
@lennyburdette should we be doing changesets now so we document changes between alpha versions? |
This commit adds support for expanding dependent types and key generation for parameters in a JSONSelection included in the transport body.
0e4f949 to
61e0bfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for expanding dependent types and key generation for parameters in a JSONSelection included in the transport body.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩