chore(federation): fix merged abstract types test#5796
Conversation
|
@dariuszkuc, please consider creating a changeset entry in |
|
CI performance tests
|
6dfb883 to
5685352
Compare
|
The |
|
A result being unstable is very undesireable. It might be due to using a plain HashMap or HashSet somewhere, as hashing is seeded with OS randomness and affects the order of the map. |
Should we then fix the non-determinism first before fixing the test? 😅 |
Indeed. Didn't notice that before. I'll revert the change. |
Due to the differences between JS and RS graph structures (JS is always topologically sorted) we occassionally end up with different parallel fetch node order....
5685352 to
8de9d35
Compare
duckki
left a comment
There was a problem hiding this comment.
With the non-determinism out of the picture, the change looks good!
Due to the differences between JS and RS graph structures (JS is always topologically sorted) we occassionally end up with different parallel fetch node order....
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩