Skip to content

chore(federation): fix merged abstract types test#5796

Merged
dariuszkuc merged 1 commit intodevfrom
requires_parallel_order
Aug 12, 2024
Merged

chore(federation): fix merged abstract types test#5796
dariuszkuc merged 1 commit intodevfrom
requires_parallel_order

Conversation

@dariuszkuc
Copy link
Member

Due to the differences between JS and RS graph structures (JS is always topologically sorted) we occassionally end up with different parallel fetch node order....


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

@dariuszkuc, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Aug 9, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@dariuszkuc dariuszkuc force-pushed the requires_parallel_order branch from 6dfb883 to 5685352 Compare August 9, 2024 18:35
@duckki
Copy link
Contributor

duckki commented Aug 10, 2024

The it_handles_complex_require_chain test is unstable and sporadically fails. We need to handle that non-determinism as well.

@goto-bus-stop
Copy link
Member

A result being unstable is very undesireable. It might be due to using a plain HashMap or HashSet somewhere, as hashing is seeded with OS randomness and affects the order of the map.

@lrlna
Copy link
Member

lrlna commented Aug 12, 2024

The it_handles_complex_require_chain test is unstable and sporadically fails. We need to handle that non-determinism as well.

Should we then fix the non-determinism first before fixing the test? 😅

@dariuszkuc
Copy link
Member Author

The it_handles_complex_require_chain test is unstable and sporadically fails. We need to handle that non-determinism as well.

Indeed. Didn't notice that before. I'll revert the change.

Due to the differences between JS and RS graph structures (JS is always topologically sorted) we occassionally end up with different parallel fetch node order....
@dariuszkuc dariuszkuc force-pushed the requires_parallel_order branch from 5685352 to 8de9d35 Compare August 12, 2024 14:08
@dariuszkuc dariuszkuc changed the title chore: update requires test with different parallel node order chore(federation): fix merged abstract types test Aug 12, 2024
@dariuszkuc dariuszkuc enabled auto-merge (squash) August 12, 2024 14:36
Copy link
Contributor

@duckki duckki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the non-determinism out of the picture, the change looks good!

@dariuszkuc dariuszkuc merged commit b337feb into dev Aug 12, 2024
@dariuszkuc dariuszkuc deleted the requires_parallel_order branch August 12, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants