Skip to content

chore(federation): refactor fragment usage counting#5784

Merged
goto-bus-stop merged 2 commits intodevfrom
renee/fragment-usages
Aug 7, 2024
Merged

chore(federation): refactor fragment usage counting#5784
goto-bus-stop merged 2 commits intodevfrom
renee/fragment-usages

Conversation

@goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Aug 7, 2024

Today's 25 minute cleanup:

  • Moves the collect_used_fragment_names family of functions to one place in the source file.
  • Remove an unnecessary temporary selection set clone (‼️)
  • Use u32 to store the counts as they can never be negative.
  • Instead of clearing the internal map with NamedFragments.retain(false), replace the whole structure with an empty one.

- Moves the `collect_used_fragment_names` family of functions to one
  place in the source file.
- Use `u32` to store the counts as they can never be negative.
- Remove an unnecessary temporary selection set clone.
- Instead of clearing the internal map with `NamedFragments.retain(false)`,
  replace the whole structure with an empty one.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

@goto-bus-stop, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Aug 7, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@goto-bus-stop goto-bus-stop enabled auto-merge (squash) August 7, 2024 09:57
@goto-bus-stop goto-bus-stop merged commit ff6a3ae into dev Aug 7, 2024
@goto-bus-stop goto-bus-stop deleted the renee/fragment-usages branch August 7, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants