chore(federation): refactor fragment usage counting#5784
Merged
goto-bus-stop merged 2 commits intodevfrom Aug 7, 2024
Merged
Conversation
- Moves the `collect_used_fragment_names` family of functions to one place in the source file. - Use `u32` to store the counts as they can never be negative. - Remove an unnecessary temporary selection set clone. - Instead of clearing the internal map with `NamedFragments.retain(false)`, replace the whole structure with an empty one.
Contributor
|
@goto-bus-stop, please consider creating a changeset entry in |
|
CI performance tests
|
dariuszkuc
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today's 25 minute cleanup:
collect_used_fragment_namesfamily of functions to one place in the source file.u32to store the counts as they can never be negative.NamedFragments.retain(false), replace the whole structure with an empty one.