Share a single Rust QP instance when using a pool of JS workers#5771
Merged
SimonSapin merged 1 commit intodevfrom Aug 5, 2024
Merged
Share a single Rust QP instance when using a pool of JS workers#5771SimonSapin merged 1 commit intodevfrom
SimonSapin merged 1 commit intodevfrom
Conversation
Config `supergraph.query_planning.experimental_parallelism` defaults to 1, but when set to something else `BridgeQueryPlannerPool` creates that many instances of `BridgeQueryPlanner` which in turn create a JS worker each. If config `experimental_query_planner_mode` is also set to `new` or `both` (current default is `legacy`), the each `BridgeQueryPlanner` would also unnecessarily create its own instance of the Rust `QueryPlanner` struct. Instead, a single `QueryPlanner` is now shared with `Arc`. Unlike JS workers, `QueryPlanner` only contains read-only data and can safely be shared between threads.
Contributor
|
@SimonSapin, please consider creating a changeset entry in |
|
CI performance tests
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config
supergraph.query_planning.experimental_parallelismdefaults to 1, but when set to something elseBridgeQueryPlannerPoolcreates that many instances ofBridgeQueryPlannerwhich in turn create a JS worker each.If config
experimental_query_planner_modeis also set toneworboth(current default islegacy), the eachBridgeQueryPlannerwould also unnecessarily create its own instance of the RustQueryPlannerstruct.Instead, a single
QueryPlanneris now shared withArc. Unlike JS workers,QueryPlanneronly contains read-only data and can safely be shared between threads. This should reduce memory use when bothsupergraph.query_planning.experimental_parallelismandexperimental_query_planner_modeare configured to non-default values.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩