Skip to content

fix(federation): fixed a mismatch after merging PR #5743#5763

Merged
goto-bus-stop merged 1 commit intodevfrom
duckki/fix-variable-usages-from-PR#5743
Aug 2, 2024
Merged

fix(federation): fixed a mismatch after merging PR #5743#5763
goto-bus-stop merged 1 commit intodevfrom
duckki/fix-variable-usages-from-PR#5743

Conversation

@duckki
Copy link
Contributor

@duckki duckki commented Aug 2, 2024

Problem: FetchNode's variable_usages field incorrectly included the "representations" variable. That caused more mismatches between JS QP and Rust QP.

Fix: Restored variable_usages to be computed without using the operation's variables field.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

- FetchNode's `variable_usages` field incorrectly included the "representations" variable.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

@duckki, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Aug 2, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I should've caught that 🫣

@goto-bus-stop goto-bus-stop merged commit 357fd36 into dev Aug 2, 2024
@goto-bus-stop goto-bus-stop deleted the duckki/fix-variable-usages-from-PR#5743 branch August 2, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants