fix(federation): fixed a mismatch after merging PR #5743#5763
Merged
goto-bus-stop merged 1 commit intodevfrom Aug 2, 2024
Merged
fix(federation): fixed a mismatch after merging PR #5743#5763goto-bus-stop merged 1 commit intodevfrom
goto-bus-stop merged 1 commit intodevfrom
Conversation
- FetchNode's `variable_usages` field incorrectly included the "representations" variable.
Contributor
|
@duckki, please consider creating a changeset entry in |
|
CI performance tests
|
goto-bus-stop
approved these changes
Aug 2, 2024
Member
goto-bus-stop
left a comment
There was a problem hiding this comment.
Thank you! I should've caught that 🫣
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: FetchNode's
variable_usagesfield incorrectly included the "representations" variable. That caused more mismatches between JS QP and Rust QP.Fix: Restored
variable_usagesto be computed without using the operation'svariablesfield.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.