Skip to content

Fix connector span test#5760

Merged
pubmodmatt merged 2 commits intonextfrom
pubmodmatt/connectors/fix_span_test
Aug 1, 2024
Merged

Fix connector span test#5760
pubmodmatt merged 2 commits intonextfrom
pubmodmatt/connectors/fix_span_test

Conversation

@pubmodmatt
Copy link

It turns out that testing tracing spans is fairly difficult. This is partially due to bugs in tracing as well as conflicts between tests due to test crates overriding global tracing settings. The previous version of the test was causing failures when run together with other tests.

Avoid all of this, and just use a simple mock to determine if the connector span was emitted with the expected fields.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@pubmodmatt pubmodmatt self-assigned this Aug 1, 2024
@pubmodmatt pubmodmatt requested a review from a team August 1, 2024 14:56
@pubmodmatt pubmodmatt requested a review from a team as a code owner August 1, 2024 14:56
@router-perf
Copy link

router-perf bot commented Aug 1, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

@pubmodmatt pubmodmatt merged commit 03659c6 into next Aug 1, 2024
@pubmodmatt pubmodmatt deleted the pubmodmatt/connectors/fix_span_test branch August 1, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants