Allow to use progressive override when using federation 2.7 and above.#5754
Merged
o0Ignition0o merged 3 commits intodevfrom Jul 31, 2024
Merged
Allow to use progressive override when using federation 2.7 and above.#5754o0Ignition0o merged 3 commits intodevfrom
o0Ignition0o merged 3 commits intodevfrom
Conversation
A bug in the way we extracted progressive override metadata from the schema would lead to the plugin not being enabled when using join 0.5.
|
CI performance tests
|
dariuszkuc
approved these changes
Jul 31, 2024
bnjjj
approved these changes
Jul 31, 2024
trevor-scheer
approved these changes
Jul 31, 2024
Contributor
trevor-scheer
left a comment
There was a problem hiding this comment.
LGTM, thank you! I am really not sure why I capped it at 0.4, I can't think of a good reason.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug in the way we extracted progressive override metadata from the schema would lead to the plugin not being enabled when using join 0.5.