Merged
Conversation
|
CI performance tests
|
goto-bus-stop
commented
Jul 31, 2024
|
|
||
| #[test] | ||
| #[should_panic(expected = r#"unused variable: `$some_var`"#)] | ||
| #[should_panic(expected = r#"snapshot assertion"#)] |
Member
Author
There was a problem hiding this comment.
The expected error changed because apollo-compiler fixed validation. This test still fails for other reasons, which will be addressed in #5743.
goto-bus-stop
commented
Jul 31, 2024
| @@ -0,0 +1,11 @@ | |||
| ### Fix GraphQL query directives validation bug | |||
Member
Author
There was a problem hiding this comment.
I'm not sure if it's worth adding a changeset for this, because as far as we know, none of our users have any query that does this... I also struggled to come up with a code example using this syntax that you could actually use for anything.
Member
There was a problem hiding this comment.
I'd keep the changeset. It's still a fix, even if it doesn't actually affect anyone.
lrlna
approved these changes
Jul 31, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
query ($var: Int) @directive(arg: $var)is now accepted - it used to raise an unused variable error for$var.I also moved some remaining apollo-rs dependency version declarations to use the
.workspace = truesyntax, to remove multiple versions of the same crate from the dependency tree.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩