Skip to content

Revert "(fix) Prevent Datadog timeout errors in logs" #5731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BrynCooke wants to merge 1 commit into from
Closed

Revert "(fix) Prevent Datadog timeout errors in logs" #5731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .changesets/fix_bryn_datadog_timeout.md
View file
Open in desktop

This file was deleted.

9 changes: 1 addition & 8 deletions apollo-router/src/plugins/telemetry/tracing/datadog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

use std::fmt::Debug;
use std::fmt::Formatter;
use std::time::Duration;

use ahash::HashMap;
use ahash::HashMapExt;
Expand Down Expand Up @@ -197,13 +196,7 @@ impl TracingConfigurator for Config {
.expect("cargo version is set as a resource default;qed")
.to_string(),
)
.with_http_client(
reqwest::Client::builder()
// https://github.com/open-telemetry/opentelemetry-rust-contrib/issues/7
// Set the idle timeout to something low to prevent termination of connections.
.pool_idle_timeout(Duration::from_millis(1))
.build()?,
)
.with_http_client(reqwest::Client::builder().build()?)
.with_trace_config(common)
.build_exporter()?;

Expand Down