Skip to content

Evaluate selectors in response stage when possible#5725

Merged
bnjjj merged 6 commits intodevfrom
bnjjj/fix_subgraph_selector_for_event
Jul 29, 2024
Merged

Evaluate selectors in response stage when possible#5725
bnjjj merged 6 commits intodevfrom
bnjjj/fix_subgraph_selector_for_event

Conversation

@bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Jul 25, 2024

As events are triggered at a specific stage (request|response|error) we can only have condition for the related stage and so sometimes you can also have selectors that can be applied at several stages (like subgraph_name to get the subgraph name). This change adds more possibilities when creating conditions on events.

Example of an event to log the raw subgraph response only on a subgraph named products, this was not working before.

telemetry:
  instrumentation:
    events:
      subgraph:
        response:
          level: info
          condition:
            eq:
            - subgraph_name: true
            - "products"

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

bnjjj added 2 commits July 25, 2024 11:31
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from a team July 25, 2024 09:42
@bnjjj bnjjj requested a review from a team as a code owner July 25, 2024 09:42
@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Jul 25, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from BrynCooke July 25, 2024 09:43
bnjjj and others added 3 commits July 25, 2024 15:01
Co-authored-by: Bryn Cooke <BrynCooke@gmail.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
…ollographql/router into bnjjj/fix_subgraph_selector_for_event
@bnjjj bnjjj requested a review from BrynCooke July 25, 2024 13:25
@bnjjj bnjjj enabled auto-merge (squash) July 25, 2024 13:34
@bnjjj bnjjj merged commit 8327775 into dev Jul 29, 2024
@bnjjj bnjjj deleted the bnjjj/fix_subgraph_selector_for_event branch July 29, 2024 08:31
@abernix abernix mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants