Skip to content

join__directive support in extract_subgraphs_from_supergraph#5720

Merged
lennyburdette merged 3 commits intodevfrom
lb/connectors-to-dev
Jul 26, 2024
Merged

join__directive support in extract_subgraphs_from_supergraph#5720
lennyburdette merged 3 commits intodevfrom
lb/connectors-to-dev

Conversation

@lennyburdette
Copy link
Copy Markdown
Contributor

@lennyburdette lennyburdette commented Jul 24, 2024

and some federation constants

this change is mostly useless at the moment because the yet-to-be-implemented connector directives are the only ones eligible for join__directive serialization


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@github-actions
Copy link
Copy Markdown
Contributor

@lennyburdette, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link
Copy Markdown

router-perf bot commented Jul 24, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Copy link
Copy Markdown
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment on .expect() style. Otherwise this should be good to go!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the message of .expect() should be explaining why the Result/Option of the value should have been there (guidance from rust docs). All of these are worded in an .assert() style when it's not actually an assert. These should read something like "join__directive(graphs:) value is an enum" or something of the sort. There are a bunch of good examples in apollo-router/src/json_ext.rs with expect statements.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the todos to jira as well? we lose track of these so easily

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and some federation constants

this change is mostly useless at the moment because the yet-to-be-implemented connector directives are the only ones eligible for join__directive serialization
@lennyburdette lennyburdette force-pushed the lb/connectors-to-dev branch from 4a19cc0 to f045e2e Compare July 26, 2024 12:10
@lennyburdette lennyburdette merged commit 51a4494 into dev Jul 26, 2024
@lennyburdette lennyburdette deleted the lb/connectors-to-dev branch July 26, 2024 12:47
@lennyburdette lennyburdette mentioned this pull request Jul 30, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants