Skip to content

improve entity cache documentation#5574

Merged
Geal merged 16 commits intodevfrom
geal/entity-cache-documentation
Aug 14, 2024
Merged

improve entity cache documentation#5574
Geal merged 16 commits intodevfrom
geal/entity-cache-documentation

Conversation

@Geal
Copy link
Contributor

@Geal Geal commented Jul 1, 2024

This is documentation for the currently in preview entity cache features. Since parts of the new features, like invalidation, are coming under separate commits, we will document them and make a changelog entry in one step instead of each commit adding their little bit.
We need to make sure that if a release is coming out, we provide a changeset and doc for what is already there, and leave the unfinished parts for the next release.

To document:

  • d940c3f
  • 3bb3f5e (this is technically already in 1.52 but was not called out)
  • 6df3b09 (same, it is already in released code by now)

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Jul 1, 2024

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

bnjjj and others added 5 commits July 12, 2024 15:15
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@abernix abernix mentioned this pull request Jul 25, 2024
Geal and others added 3 commits July 30, 2024 18:41

You can add a new attribute on the subgraph span for the number of cache hits. For example:

```yaml title="todo_router.yaml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still todo? Same for the other examples.

@Geal
Copy link
Contributor Author

Geal commented Aug 9, 2024

potential rhai script to add:

let claims = request.context[Router.APOLLO_AUTHENTICATION_JWT_CLAIMS];

  if claims != () {
    let private_id = claims["sub"];
    request.context["private_id"] = private_id;
  }

@Geal Geal marked this pull request as ready for review August 13, 2024 15:15
@Geal Geal requested a review from a team as a code owner August 13, 2024 15:15
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
@Geal Geal enabled auto-merge (squash) August 13, 2024 16:28
@Geal Geal merged commit 7752a1f into dev Aug 14, 2024
@Geal Geal deleted the geal/entity-cache-documentation branch August 14, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants