Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
CI performance tests
|
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Merged
shorgi
reviewed
Jul 29, 2024
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
BrynCooke
reviewed
Aug 7, 2024
|
|
||
| You can add a new attribute on the subgraph span for the number of cache hits. For example: | ||
|
|
||
| ```yaml title="todo_router.yaml" |
Contributor
There was a problem hiding this comment.
Is this still todo? Same for the other examples.
Contributor
Author
|
potential rhai script to add: |
Co-authored-by: Bryn Cooke <BrynCooke@gmail.com>
shorgi
approved these changes
Aug 13, 2024
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Geal
commented
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is documentation for the currently in preview entity cache features. Since parts of the new features, like invalidation, are coming under separate commits, we will document them and make a changelog entry in one step instead of each commit adding their little bit.
We need to make sure that if a release is coming out, we provide a changeset and doc for what is already there, and leave the unfinished parts for the next release.
To document:
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩