-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tell jemalloc to use 64-KiB pages #5566
base: dev
Are you sure you want to change the base?
Conversation
CI performance tests
|
It's probably the right thing to do at this point. I really hoped that they'd fix this inside jemalloc, but ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we are happy only having this in CI or if it's something we need to set for local builds...
Maybe we could use this to enforce it for the project, even locally ? cc @garypen. @SimonSapin did you already use this ? |
@bnjjj That's a good suggestion I think. I suppose it would only apply to people developing/testing on Linux (we don't use jemalloc on macOS/Windows). Could you try it out? |
Description here
Fixes #3382
For more detail about the issue:
This change is similar to what other projects are doing. We've been using that internally as well.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩