Skip to content

Add validation check for entity arg on root Query field#5468

Merged
tayrrible merged 5 commits intoconnectorsfrom
taylor/cnn-140
Jun 18, 2024
Merged

Add validation check for entity arg on root Query field#5468
tayrrible merged 5 commits intoconnectorsfrom
taylor/cnn-140

Conversation

@tayrrible
Copy link
Copy Markdown
Contributor

@tayrrible tayrrible commented Jun 17, 2024

Description here

The entity arg should only be used on the root Query field.

This PR adds a validation check to return an error message if used on any other field.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@github-actions
Copy link
Copy Markdown
Contributor

@tayrrible, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link
Copy Markdown

router-perf bot commented Jun 17, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • no-tracing - Basic stress test, no tracing
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • step - Basic stress test that steps up the number of users over time
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • large-request - Stress test with a 1 MB request payload
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • const - Basic stress test that runs with a constant number of users

@tayrrible tayrrible changed the base branch from dev to connectors June 17, 2024 22:47
@tayrrible tayrrible requested a review from a team June 17, 2024 22:52
@tayrrible tayrrible marked this pull request as ready for review June 18, 2024 15:20
@tayrrible tayrrible requested review from a team and lennyburdette June 18, 2024 15:20
Copy link
Copy Markdown
Contributor

@dylan-apollo dylan-apollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tayrrible tayrrible merged commit 1880c8c into connectors Jun 18, 2024
@tayrrible tayrrible deleted the taylor/cnn-140 branch June 18, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants