Add generate_query_fragments configuration option#4885
Merged
nicholascioli merged 14 commits intoapollographql:devfrom Apr 5, 2024
Merged
Add generate_query_fragments configuration option#4885nicholascioli merged 14 commits intoapollographql:devfrom
generate_query_fragments configuration option#4885nicholascioli merged 14 commits intoapollographql:devfrom
Conversation
|
CI performance tests
|
Contributor
|
Looks like documentation still needs updating. |
Contributor
Author
|
@BrynCooke I added some docs for the new option as well as the existing option since they're pretty related. Let me know if you have any opinions on where the new section belongs, if you think it should go somewhere that isn't where I put it. |
Geal
approved these changes
Apr 2, 2024
Contributor
|
the failing integration tests could be due to a cache key changing with the option https://app.circleci.com/pipelines/github/apollographql/router/20059/workflows/bf8a774f-1e0d-49eb-a5ec-4324d6ac90f0/jobs/134413 |
BrynCooke
requested changes
Apr 2, 2024
BrynCooke
approved these changes
Apr 3, 2024
trevor-scheer
commented
Apr 3, 2024
Contributor
Author
|
Thank you both! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the loop on apollographql/federation#2958
reuse_query_fragments.