Skip to content

docs(logging): Change contains_attributes to when_header#3127

Merged
abernix merged 6 commits intoapollographql:devfrom
obrien-k:obrien-k/logging
May 24, 2023
Merged

docs(logging): Change contains_attributes to when_header#3127
abernix merged 6 commits intoapollographql:devfrom
obrien-k:obrien-k/logging

Conversation

@obrien-k
Copy link
Contributor

This was correct in the original PR, tested to confirm when_header works, contains_attributes returns an error due to an invalid config field.

Description here

Fixes a customer request

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

This was correct in the original PR, tested to confirm when_header works, contains_attributes returns an error due to invalid config field.
@obrien-k obrien-k requested a review from StephenBarlow as a code owner May 22, 2023 21:18
@router-perf
Copy link

router-perf bot commented May 22, 2023

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users

obrien-k and others added 3 commits May 23, 2023 08:14
Co-authored-by: Stephen Barlow <barlow.stephen+git@gmail.com>
Co-authored-by: Stephen Barlow <barlow.stephen+git@gmail.com>
Co-authored-by: Stephen Barlow <barlow.stephen+git@gmail.com>
@abernix abernix changed the title Change contains_attributes to when_header docs(logging): Change contains_attributes to when_header May 24, 2023
@abernix abernix merged commit c679c16 into apollographql:dev May 24, 2023
@abernix
Copy link
Member

abernix commented May 24, 2023

Thanks! Merged. I'm assuming "original PR" here was #2040, so I added that to the squash merge to create/link context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants