docs(logging): Change contains_attributes to when_header#3127
Merged
abernix merged 6 commits intoapollographql:devfrom May 24, 2023
Merged
docs(logging): Change contains_attributes to when_header#3127abernix merged 6 commits intoapollographql:devfrom
contains_attributes to when_header#3127abernix merged 6 commits intoapollographql:devfrom
Conversation
This was correct in the original PR, tested to confirm when_header works, contains_attributes returns an error due to invalid config field.
|
CI performance tests
|
Co-authored-by: Stephen Barlow <barlow.stephen+git@gmail.com>
Co-authored-by: Stephen Barlow <barlow.stephen+git@gmail.com>
Co-authored-by: Stephen Barlow <barlow.stephen+git@gmail.com>
bnjjj
approved these changes
May 23, 2023
o0Ignition0o
approved these changes
May 24, 2023
contains_attributes to when_header
Member
|
Thanks! Merged. I'm assuming "original PR" here was #2040, so I added that to the squash merge to create/link context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was correct in the original PR, tested to confirm when_header works, contains_attributes returns an error due to an invalid config field.
Description here
Fixes a customer request
Checklist
Complete the checklist (and note appropriate exceptions) before a final PR is raised.
Exceptions
Note any exceptions here
Notes
[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as
manual test