fix(hotreload): do not watch the entire directory, only config file#2289
Merged
fix(hotreload): do not watch the entire directory, only config file#2289
Conversation
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
Geal
approved these changes
Dec 19, 2022
o0Ignition0o
suggested changes
Dec 19, 2022
Contributor
o0Ignition0o
left a comment
o0Ignition0o
left a comment
There was a problem hiding this comment.
The configuration supports a rhai scripts directory https://www.apollographql.com/docs/router/customizations/rhai/
is this being watched?
Contributor
Author
|
Not related to the hot reload of rhai |
o0Ignition0o
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2287