Skip to content

Comments

As we are now using metrics for all requests we should not set operation count#2286

Merged
BrynCooke merged 2 commits intodevfrom
bryn/zero-trace-operation-count
Dec 19, 2022
Merged

As we are now using metrics for all requests we should not set operation count#2286
BrynCooke merged 2 commits intodevfrom
bryn/zero-trace-operation-count

Conversation

@BrynCooke
Copy link
Contributor

This change has not been released but the issue was introduced in #2277 Fixes #2267
Metrics will always have the definitive operation count.

@github-actions

This comment has been minimized.

@BrynCooke BrynCooke force-pushed the bryn/zero-trace-operation-count branch from 6afd38e to f831a17 Compare December 19, 2022 09:46
Metrics is the only way operation count should be incremented.

This change has not been released but the issue was introduced in #2277
Fixes #2267
@BrynCooke BrynCooke force-pushed the bryn/zero-trace-operation-count branch from f831a17 to 870b3bf Compare December 19, 2022 10:12
@BrynCooke BrynCooke merged commit 5645b76 into dev Dec 19, 2022
@BrynCooke BrynCooke deleted the bryn/zero-trace-operation-count branch December 19, 2022 10:46
@abernix abernix added this to the v1.7.0 milestone Dec 22, 2022
@abernix abernix mentioned this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Field references missing on Apollo traces

3 participants