Only rebuild protos if proto source changes#2283
Merged
Geal merged 2 commits intoapollographql:devfrom Dec 21, 2022
Merged
Conversation
scottdouglas1989
force-pushed
the
fixes-cargo-build-cache-for-protos
branch
from
60f3be3 to
69b51a4
Compare
bnjjj
approved these changes
Dec 19, 2022
o0Ignition0o
approved these changes
Dec 19, 2022
Geal
reviewed
Dec 20, 2022
| content = content.replace("[(js_preEncoded)=true]", ""); | ||
| std::fs::write(&reports_out, &content)?; | ||
|
|
||
| println!("cargo:rerun-if-changed={}", reports_src.to_str().unwrap()); |
Contributor
Author
There was a problem hiding this comment.
When I was first investigating the rebuild, it was unclear to me with it further up, I ended up with it at the bottom of the build right before handing off to tonic_build.
Worth noting, the location of this line does not affect cargo's change detection.
Contributor
|
thanks for the help! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tonic_buildchanges timestamps by a few nanos.Router only needs to re-run
tonic_buildifreports.protochanges, and that's managed by the build.rs file already viaprintln!("cargo:rerun-if-changed={}", reports_src.to_str().unwrap());This just disables
tonic_build's rerun emits so it's fully managed byapollo-router