hot reload: replace notify recommended watcher with poll watcher#2276
Merged
hot reload: replace notify recommended watcher with poll watcher#2276
Conversation
added 4 commits
December 15, 2022 15:51
fixes: #2245 To get consistent behaviour across multiple platforms and file systems. The watcher may not be as reactive, but I think it's reactive enough for things which shouldn't change frequently.
for less waiting around.
garypen
requested review from
BrynCooke and
SimonSapin
and removed request for
a team
added 2 commits
December 15, 2022 16:37
I installed rustc on my windows PC and ran the tests repeatedly as they were and they worked fine. I can only conclude that the CI windows machines are really slow, so put the delay back to 500 ms so that tests continue to pass in CI.
bnjjj
approved these changes
Dec 16, 2022
BrynCooke
approved these changes
Dec 16, 2022
Merged
abernix
changed the title
abernix
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get consistent behaviour across multiple platforms and file systems.
fixes: #2245
The watcher may not be as reactive, but I think it's reactive enough for things which shouldn't change frequently.
As a bonus, we no longer get events if the content is the same, so less spurious reloads, which is good. That means I had to modify the tests though to use different contents.
The rhai file watching appeared to be working fine, but to be safe I converted it to the PollWatcher as well.