Feature: Apollo uplink: connection timeouts#2271
Merged
o0Ignition0o merged 5 commits intodevfrom Dec 15, 2022
Merged
Conversation
This PR adds a timeout to apollo uplink schema polling (30s by default, configurable) and reports (90s, not configurable).
Geal
approved these changes
Dec 15, 2022
Contributor
Author
|
I m going to rename APOLLO_UPLINK_CLIENT_TIMEOUT to APOLLO_UPLINK_TIMEOUT |
BrynCooke
approved these changes
Dec 15, 2022
Contributor
BrynCooke
left a comment
BrynCooke
left a comment
There was a problem hiding this comment.
Approved, but let's remove client from apollo-uplink-client-timeout to give apollo-uplink-timeout
bnjjj
suggested changes
Dec 15, 2022
bnjjj
approved these changes
Dec 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a timeout to apollo uplink schema polling (30s by default, configurable) and reports (90s, not configurable).