rhai: add new values() fn for headers with multiple values#2258
Merged
Conversation
added 2 commits
December 13, 2022 11:13
fixes: #2255 We can't update the indexer until we release router 2.0, since that would be an incompatible change, but we can add a new function which provides access to multiple values. Here's an illustrative snippet: // Create some headers to work with: response.headers["scalar"] = "value 1"; response.headers["array"] = ["value 1", "value 2", "value 3"]; // We still see scalar header keys as a single string print(`scalar: ${response.headers["scalar"]}`); // If we know we have an array use the `values` fn print(`array: ${response.headers.values("array")}`); print(`array[2]: ${response.headers.values("array")[2]}`); // If we access a multi-value header using the indexer, then: print(`array: ${response.headers["array"]}`); // we get the existing behaviour, the first value as a string
This comment has been minimized.
This comment has been minimized.
BrynCooke
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #2255
We can't update the indexer until we release router 2.0, since that
would be an incompatible change, but we can add a new function which
provides access to multiple values.
Here's an illustrative snippet:
Needs documentationDONE