Conversation
added 2 commits
December 13, 2022 12:08
Contributor
|
@Geal, please add a |
garypen
reviewed
Dec 13, 2022
Contributor
There was a problem hiding this comment.
I think we could just make the configuration change from usize to NonZeroUsize and not document it. There are much more substantial changes taking place to config and we are calling them "compatible". Maybe mark it as a "breaking" change in the changelog.
Contributor
Author
|
my view here is that it does not really make sense to set the capacity to zero. I'm not sure there are cases where we would want to disable the cache entirely, except when debugging, and even then I have not felt the need for it |
bnjjj
suggested changes
Dec 14, 2022
Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com>
bnjjj
approved these changes
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some dependency updates require more invloved changes. Here LRU now requires a NonZeroUsize for the capacity argument. This changes the minimal value in the configuration file. Do we consider that this is a breaking change?